Skip to content

Bump Go to 1.26.3#618

Open
stuggi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
stuggi:go-1.26.3-bump
Open

Bump Go to 1.26.3#618
stuggi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
stuggi:go-1.26.3-bump

Conversation

@stuggi

@stuggi stuggi commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Go: 1.24.4 -> 1.26.3
  • operator-sdk: v1.41.1 -> v1.42.3
  • golangci-lint: v2.4.0 -> v2.12.2
  • GOTOOLCHAIN_VERSION: go1.24.0 -> go1.26.0
  • go-toolset image: 1.24 -> 1.26
  • .ci-operator.yaml: ci-build-root-golang-1.24-sdk-1.41.1 -> ci-build-root-golang-1.26-sdk-1.42.3
  • ginkgo: v2.28.2 -> v2.32.0
  • gomega: v1.42.0 -> v1.42.1

Code changes required by the bump:

  • Replace fmt.Sprintf host:port patterns with net.JoinHostPort (Go 1.25+ hostport vet check) in memcached_controller.go, redis_controller.go, transporturl_controller.go, configmap.go, webhook_suite_test.go
  • Fix gofmt formatting in apis/ (Go 1.26 import ordering and indentation)

Disabled govet inline analyzer in .golangci.yaml — Go 1.26 emits false-positive "cannot inline: type parameter inference not yet supported" for generic functions like maps.Copy and slices.Sorted.

Jira: OSPRH-30997

Depends-On: openstack-k8s-operators/openstack-operator#1977
Depends-On: openstack-k8s-operators/install_yamls#1153

@openshift-ci openshift-ci Bot requested review from antonioromito and dciabrin July 9, 2026 15:50
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 9, 2026
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 9, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/775c64c077b24774b60a259753c7da2a

❌ openstack-k8s-operators-content-provider FAILURE in 10m 28s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 5m 00s

@stuggi

stuggi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/test infra-operator-build-deploy-kuttl

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a32024f0c7ee4a818ca77e751a299235

❌ openstack-k8s-operators-content-provider FAILURE in 12m 32s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 6m 47s

@stuggi @claude
Bump Go to 1.26.3
2187136 
- Go: 1.24.4 -> 1.26.3
- operator-sdk: v1.41.1 -> v1.42.3
- golangci-lint: v2.4.0 -> v2.12.2
- GOTOOLCHAIN_VERSION: go1.24.0 -> go1.26.0
- go-toolset image: 1.24 -> 1.26
- .ci-operator.yaml: ci-build-root-golang-1.24-sdk-1.41.1 -> ci-build-root-golang-1.26-sdk-1.42.3
- ginkgo: v2.28.2 -> v2.32.0
- gomega: v1.42.0 -> v1.42.1

Code changes required by the bump:
- Replace fmt.Sprintf host:port patterns with net.JoinHostPort (Go 1.25+ hostport vet check)
  in memcached_controller.go, redis_controller.go, transporturl_controller.go,
  configmap.go, webhook_suite_test.go
- Fix gofmt formatting in apis/ (Go 1.26 import ordering and indentation)

Jira: OSPRH-30997

Depends-On: openstack-k8s-operators/lib-common#715

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/89069e993b5144e2af29c7b121cfb990

❌ openstack-k8s-operators-content-provider FAILURE in 11m 31s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 41s

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/infra-operator-build-deploy-kuttl 2187136 link true /test infra-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi

stuggi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a31ec13bb8b444b1846477318b4d0666

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 37m 04s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 49m 02s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 20s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonioromito antonioromito Awaiting requested review from antonioromito
@dciabrin dciabrin Awaiting requested review from dciabrin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

approved do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stuggi